Bug 28075

Summary: Remove trailing whitespaces from all database files
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, aroben, beidson, dglazkov, eric
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch none

Dumitru Daniliuc
Reported 2009-08-07 11:05:34 PDT
Lots of database files have trailing whitespaces in them. We should clean that up.
Attachments
patch (62.51 KB, patch)
2009-08-26 16:40 PDT, Dumitru Daniliuc 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2009-08-26 16:40:39 PDT
Created attachment 38647 [details] patch Removed all trailing whitespaces in all files in WebCore/storage/.
Adam Barth
Comment 2 2009-08-26 21:28:51 PDT
Comment on attachment 38647 [details] patch ok
Eric Seidel (no email)
Comment 3 2009-08-26 21:39:55 PDT
Comment on attachment 38647 [details] patch Rejecting patch 38647 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Adam Barth
Comment 4 2009-08-26 21:57:29 PDT
Comment on attachment 38647 [details] patch Hum... Seems unlikley. Let's try this again.
Eric Seidel (no email)
Comment 5 2009-08-26 22:05:31 PDT
Comment on attachment 38647 [details] patch Rejecting patch 38647 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Adam Barth
Comment 6 2009-08-26 22:23:12 PDT
Comment on attachment 38647 [details] patch Clearing flags on attachment: 38647 Committed r47808: <http://trac.webkit.org/changeset/47808>
Adam Barth
Comment 7 2009-08-26 22:23:19 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 8 2009-08-26 23:26:56 PDT
Sorry. run-webkit-tests had left an httpd process running, causing all patches to fail the httpd tests. :(
Note You need to log in before you can comment on or make changes to this bug.