Bug 280744
| Summary: | JSDOMPromiseDeferred.h:307:20: "error: use 'template' keyword to treat 'resolve' as a dependent template name" with some Clang versions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Abrar Rahman Protyasha <a_protyasha> |
| Component: | WebCore Misc. | Assignee: | Abrar Rahman Protyasha <a_protyasha> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | a_protyasha, ddkilzer, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Abrar Rahman Protyasha
rdar://136932730
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Abrar Rahman Protyasha
This is a valid diagnostic, because `m_promise` is indeed a member template specialization and the `resolve()` call explicitly depends on a template parameter, so we must adhere to clause 13.3/3.4 of the current working draft of the C++ standard.
https://eel.is/c++draft/temp#:~:text=The%20keyword%20template%20is%20used%20to%20indicate%20that%20a%20dependent%20qualified%20name%20(%5Btemp.dep.type%5D)%20denotes%20a%20template%20where%20an%20expression%20might%20appear
Abrar Rahman Protyasha
Pull request: https://github.com/WebKit/WebKit/pull/34566
EWS
Committed 284560@main (01c06ea002c2): <https://commits.webkit.org/284560@main>
Reviewed commits have been landed. Closing PR #34566 and removing active labels.
David Kilzer (:ddkilzer)
<rdar://problem/140038002>
David Kilzer (:ddkilzer)
<rdar://136932730>
EWS
Committed 283286.486@safari-7620-branch (c44b1c0fb102): <https://commits.webkit.org/283286.486@safari-7620-branch>
Reviewed commits have been landed. Closing PR #2294 and removing active labels.