Bug 280719
| Summary: | Stop using class-level JS_EXPORT_PRIVATE for JavaScriptCore/inspector | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> |
| Component: | JavaScriptCore | Assignee: | Fujii Hironori <Hironori.Fujii> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Fujii Hironori
Stop using class-level JS_EXPORT_PRIVATE for JavaScriptCore/inspector
https://webkit.slack.com/archives/CU64U6FDW/p1727386191584539?thread_ts=1727381875.279419&cid=CU64U6FDW
> I think method level export is better due to various reasons,
> 1. that becomes boundary and LTO does not work if it is used (e.g. WTF export)
> 2. Most of JSC's class JS_EXPORT_PRIVATE was coming from B3, which requires very fine-grained control and testing from testb3 etc., and I think that's the reason.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/34539
EWS
Committed 284744@main (28b90713af7c): <https://commits.webkit.org/284744@main>
Reviewed commits have been landed. Closing PR #34539 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/137390144>