Bug 280547
| Summary: | [JSC] performJITMemcpy zero-checking's diagnostics should be improved | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | Keywords: | InRadar |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://136858657
The existing feature checks for the presence of long (>16B) runs of 0-bytes in the output buffer after a JIT memcpy completes.
We also want to know whether the 0s were in the original source buffer, or whether they might have been introduced in the intervening time-period (e.g. during the linking stage). We can do this without performance overhead by checking the source buffer before we crash.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/34392
EWS
Committed 284559@main (34d00da35e69): <https://commits.webkit.org/284559@main>
Reviewed commits have been landed. Closing PR #34392 and removing active labels.
EWS
Committed 283286.178@safari-7620-branch (9bd7e9e38d97): <https://commits.webkit.org/283286.178@safari-7620-branch>
Reviewed commits have been landed. Closing PR #1956 and removing active labels.