Bug 280309
Summary: | [Text Directionality] REGRESSION(282648@main): Updating the auto text directionality of the element's ancestors is very expensive | ||
---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
Component: | DOM | Assignee: | Said Abou-Hallawa <sabouhallawa> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Said Abou-Hallawa
If the body of a large web page has the following markup <body dir="auto">, loading this page will be very slow. The reason for this performance issue, all the nodes will traverse the DOM tree upwards when they are inserted in their anchors. This traversal is not needed if the dir attribute was not changed and the effective text directionality of the element is the same as the effective text directionality of its parent. In this case this element won't affect its ancestors.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://136385909
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/34201
EWS
Committed 284339@main (53c053e2da00): <https://commits.webkit.org/284339@main>
Reviewed commits have been landed. Closing PR #34201 and removing active labels.
EWS
Committed 283286.167@safari-7620-branch (0d89c31a0da4): <https://commits.webkit.org/283286.167@safari-7620-branch>
Reviewed commits have been landed. Closing PR #1946 and removing active labels.