Bug 280243
| Summary: | Better error message for JIT tier dependencies | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | tannal2409 |
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bfan2, jbedard, Morningstar, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
tannal2409
E.g. If DFG and FTL is enabled while baseline is not, we need to print error message instead of disable them silently.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Could you please clarify the request? Where should this log go?
tannal2409
This is an issue created by `git-webkit pr`.
The pr is to fix two FIXME comment.
The pr is here.
https://github.com/WebKit/WebKit/pull/34139
But they don't link together.
Do you know how can I update my pr and linked with the issue?
Alexey Proskuryakov
I see. This probably didn't work because the commit message it not formatted according to project style, and doesn't link to the bug. I'm surprised that git-webkit has let it through.
Brianna Fan
We don't do any validation of the commit message until merging, so it's up to the user to follow the template that's given.
If you construct a new commit `git webkit commit` can help you use the right format. Then you can paste in the bug URL and your PR should be linked to this bug.
Radar WebKit Bug Importer
<rdar://problem/137015486>
EWS
Committed 284499@main (389c22b6c90f): <https://commits.webkit.org/284499@main>
Reviewed commits have been landed. Closing PR #34139 and removing active labels.