Bug 280209
| Summary: | Use LazyNeverDestroyed in `static TextCheckerState& mutableState()` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Wolfe <charliew> |
| Component: | WebKit Misc. | Assignee: | Charlie Wolfe <charliew> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Charlie Wolfe
Speculative fix. Crash reports indicate that mutableState() can be corrupted such that it contains non-bool values. Use LazyNeverDestroyed + dispatch_once to avoid issues when statically initializing this object from multiple threads.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Charlie Wolfe
<rdar://problem/133862081>
Charlie Wolfe
Pull request: https://github.com/WebKit/WebKit/pull/34107
EWS
Committed 284120@main (0d08a5fd7147): <https://commits.webkit.org/284120@main>
Reviewed commits have been landed. Closing PR #34107 and removing active labels.
EWS
Committed 280938.373@safari-7619-branch (f4756285b285): <https://commits.webkit.org/280938.373@safari-7619-branch>
Reviewed commits have been landed. Closing PR #1882 and removing active labels.
EWS
Committed 283286.127@safari-7620-branch (2f4bc0404a97): <https://commits.webkit.org/283286.127@safari-7620-branch>
Reviewed commits have been landed. Closing PR #1898 and removing active labels.