Summary: | willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | Tools / Tests | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fishd | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2009-08-04 19:02:56 PDT
I'm happy to help implement this, and either of your suggestions are fine by me. Would we only enable willCacheResponse for the http/tests/misc/willCacheResponse-delegate-callback.html layout test? dumpResourceLoadCallbacks() doesn't technically take any arguments. I see that some tests pass a 'true' parameter to it, but the code ignores all parameters and just blindly sets m_dumpResourceLoadCallbacks to true. So, I think a new dumpWillCacheResponse is probably better. I'm going to go with that. Created attachment 34153 [details]
v1 patch - adds layoutTestController.dumpWillCacheResponse()
Landed as: http://trac.webkit.org/changeset/46809 So confused about Darin Adler reviewing Darin Fisher's patch and all bugzilla tells me is "darin: review+" ;) Looks good - thanks, Darin (Fisher)! Actually... This will break some tests that have Tiger/Windows/Leopard/SnowLeopard specific results checked in. I'll try to clean up those as the build bots are running into them now. I landed http://trac.webkit.org/changeset/46810 to rebaseline the Tiger-specific results for 2 of these tests, and http://trac.webkit.org/changeset/46811 to remove the Windows specific results for 4 of these tests, as they now match the cross-platform results. http://trac.webkit.org/changeset/46812 to remove Tiger-specific results on the 6 tests that no longer dump willCacheResponse(). In a comedy of errors, restoring those 4 windows-specific results (didn't run diff on them correctly, they *did* have differences) http://trac.webkit.org/changeset/46813 |