Bug 279874

Summary:	[2.46.0][gstreamer] Build error with GST_DISABLE_GST_DEBUG
Product:	WebKit	Reporter:	Xi Ruoyao <xry111>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal
Priority:	P2
Version:	WebKit Local Build
Hardware:	PC
OS:	Linux

Xi Ruoyao

Reported 2024-09-18 00:38:54 PDT

When gstreamer is built with -D gst_debug=false, GST_DISABLE_GST_DEBUG is defined and webkitgtk-2.46.0 FTBFS with: In file included from /home/xry111/sources/12.3/webkitgtk-2.46.0/b/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-53.cpp:3: /home/xry111/sources/12.3/webkitgtk-2.46.0/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: In member function ‘virtual GstDebugCategory* WebCore::MediaLogObserver::debugCategory() const’: /home/xry111/sources/12.3/webkitgtk-2.46.0/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:147:16: error: ‘webkit_media_player_debug’ was not declared in this scope 147 | return webkit_media_player_debug; | ^~~~~~~~~~~~~~~~~~~~~~~~~ because GST_DEBUG_CATEGORY(webkit_media_player_debug) is expanded to a dummy: #define GST_DEBUG_CATEGORY(var) void _gst_debug_dummy_##var (void)

Attachments
Add attachment proposed patch, testcase, etc.

Xi Ruoyao

Comment 1 2024-09-18 01:05:32 PDT

https://github.com/WebKit/WebKit/pull/33814

Xi Ruoyao

Comment 2 2024-09-18 01:16:58 PDT

*** This bug has been marked as a duplicate of bug 279435 ***

Note You need to log in before you can comment on or make changes to this bug.