| Summary: | Cannot scroll for box-reflect:right | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shinichiro Hamaji <hamaji> | ||||||||||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | abarth | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 34054 [details]
Patch v1
---
7 files changed, 67 insertions(+), 3 deletions(-)
Created attachment 34057 [details]
Patch v2
---
7 files changed, 67 insertions(+), 3 deletions(-)
I should have sent a png image in the patch. Created attachment 34066 [details]
Patch v3
---
9 files changed, 96 insertions(+), 4 deletions(-)
Sorry, I forgot to add the html file of layout test and the change of expected results. Comment on attachment 34066 [details]
Patch v3
Looks good to me. We could probably even make this a dumpAsText test. But this is also OK as is.
(In reply to comment #6) > (From update of attachment 34066 [details]) > Looks good to me. We could probably even make this a dumpAsText test. But > this is also OK as is. This test is checking if scrollbar exists (if the size of reflected images are considered, the scrollbar should apprear). I think this kind of test can be done by dumpAsText test. Or, can we get overflowWidth from JavaScript? Created attachment 34071 [details]
Patch v4
---
8 files changed, 106 insertions(+), 4 deletions(-)
> This test is checking if scrollbar exists (if the size of reflected images are
> considered, the scrollbar should apprear). I think this kind of test can be
> done by dumpAsText test. Or, can we get overflowWidth from JavaScript?
Ah, I've found the way. I could change the position of scroll bar to see if the scroll bar is working.
Comment on attachment 34071 [details]
Patch v4
Still extra junk at the end of the test text output. But looks fine.
Created attachment 34244 [details]
Patch v5
---
10 files changed, 121 insertions(+), 4 deletions(-)
Comment on attachment 34244 [details] Patch v5 Clearing review flag on attachment: 34244 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/reflections/reflection-overflow-scroll-expected.txt A LayoutTests/fast/reflections/reflection-overflow-scroll.html A LayoutTests/fast/reflections/resources/reflection-overflow-scroll.js M LayoutTests/platform/mac/fast/reflections/reflection-nesting-expected.txt M LayoutTests/platform/mac/fast/repaint/reflection-redraw-expected.txt M WebCore/ChangeLog M WebCore/rendering/RenderBlock.cpp M WebKitTools/ChangeLog M WebKitTools/Scripts/make-js-test-wrappers Committed r46889 M WebCore/ChangeLog M WebCore/rendering/RenderBlock.cpp M LayoutTests/platform/mac/fast/repaint/reflection-redraw-expected.txt M LayoutTests/platform/mac/fast/reflections/reflection-nesting-expected.txt M LayoutTests/ChangeLog A LayoutTests/fast/reflections/reflection-overflow-scroll-expected.txt A LayoutTests/fast/reflections/reflection-overflow-scroll.html A LayoutTests/fast/reflections/resources/reflection-overflow-scroll.js M WebKitTools/ChangeLog M WebKitTools/Scripts/make-js-test-wrappers r46889 = e8e74017eb842f4b9ac3313823d6b8fb47f69f56 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46889 All reviewed patches have been landed. Closing bug. |
Created attachment 34052 [details] Test case See the attached test case. For vertical reflection, we can move scrollbar to see the reflected image. However, we don't see a scrollbar for horizontal reflection. I'll send a patch soon later.