Bug 279699

Summary: Nested inlines' vertical alignment is wrong when line-fit-edge is set
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, ntim, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 279717    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2024-09-13 15:22:34 PDT
<rdar://135962993>
Attachments
Patch (3.14 KB, patch)
2024-09-13 15:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.14 KB, patch)
2024-09-14 09:22 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (3.14 KB, patch)
2024-09-15 05:36 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-09-13 15:25:33 PDT
Created attachment 472552 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2024-09-13 18:38:01 PDT
Comment on attachment 472552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472552&action=review > LayoutTests/fast/inline/nested-inline-boxes-with-line-fit-edge.html:8 > + line-fit-edge: cap alphabetic; would be good to have WPT for line-fit-edge
alan
Comment 3 2024-09-14 09:22:28 PDT
Created attachment 472557 [details] Patch
alan
Comment 4 2024-09-14 09:32:24 PDT
(the integral change (bug 279717) needs to land first to make this test pass)
alan
Comment 5 2024-09-14 09:34:09 PDT
(In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 472552 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=472552&action=review > > > LayoutTests/fast/inline/nested-inline-boxes-with-line-fit-edge.html:8 > > + line-fit-edge: cap alphabetic; > > would be good to have WPT for line-fit-edge Will talk to Elika about line-fit-edge coverage for WPT.
alan
Comment 6 2024-09-15 05:36:44 PDT
Created attachment 472564 [details] [fast-cq]Patch
EWS
Comment 7 2024-09-15 08:03:37 PDT
Committed 283682@main (d54de3189d86): <https://commits.webkit.org/283682@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472564 [details].
EWS
Comment 8 2024-09-19 07:52:26 PDT
Committed 283286.92@safari-7620-branch (26fae845736e): <https://commits.webkit.org/283286.92@safari-7620-branch> Reviewed commits have been landed. Closing PR #1830 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.