Bug 279660
| Summary: | REGRESSION(283334@main): [GLIB] Script for updating third-party libs does not work anymore for flatpak | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=279261 | ||
Carlos Alberto Lopez Perez
Since 283334@main the scripts update-webkitgtk-libs and update-webkitwpe-libs does not work anymore.
This is because the call to the script update-webkit-flatpak is now inside now a condition shouldUseFlatpak() that is always false at the invocation of that script due to this two reasons:
1. The subroutine shouldUseFlatpak() returns false if the ports is not specified, and this two scripts are usually called without passed the flag --gtk or --wpe
2. Even if you call the script passing the port as in "update-webkitgtk-libs --gtk" shouldUseFlatpak() will only return true if the flatpak is already installed, but it will not return true on the first run (no WebKitBuild dir) and we want to default to using flatpak unless the environment tells us to do something different.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/33609
EWS
Committed 283621@main (6ddc6a2f2f12): <https://commits.webkit.org/283621@main>
Reviewed commits have been landed. Closing PR #33609 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/135955438>