Bug 279619 – REGRESSION(283521@main): [MacOS wk2 Debug EWS] storage limit and cache-storage tests are crashing with ASSERTION FAILED: m_thread.ptr() == &Thread::current()

• Component: New Bugs
• Status: RESOLVED FIXED

[Marta Darbinyan]

The following tests are pre-existing failure in EWS and crashes on MacOS main with assert.

http/tests/IndexedDB/storage-limit-1.https.html
http/tests/IndexedDB/storage-limit-2.https.html 
http/wpt/cache-storage/cache-quota-add.any.html
http/wpt/cache-storage/cache-quota-after-restart.any.html 
http/wpt/cache-storage/cache-quota.any.html
http/wpt/cache-storage/quota-third-party.https.html storage/filesystemaccess/sync-access-handle-storage-limit-worker.html
storage/indexeddb/request-size-estimate.html 
storage/indexeddb/storage-limit.html


Errors:
stderr:
ASSERTION FAILED: m_thread.ptr() == &Thread::current()
/Volumes/Data/worker/macOS-Sonoma-Debug-WK2-Tests-EWS/build/WebKitBuild/Debug/usr/local/include/wtf/SingleThreadIntegralWrapper.h(47) : void WTF::SingleThreadIntegralWrapper<unsigned int>::assertThread() const [IntegralType = unsigned int]
1   0x12297adfc WTF::SingleThreadIntegralWrapper<unsigned int>::assertThread() const
2   0x122e096c0 WTF::SingleThreadIntegralWrapper<unsigned int>::operator++()
3   0x123d04070 WTF::CanMakeCheckedPtrBase<WTF::SingleThreadIntegralWrapper<unsigned int>, unsigned int, (WTF::DefaultedOperatorEqual)0>::incrementPtrCount() const
4   0x12426b264 WTF::CheckedPtr<WebKit::OriginStorageManager, WTF::RawPtrTraits<WebKit::OriginStorageManager>>::refIfNotNull()
5   0x12426b218 WTF::CheckedPtr<WebKit::OriginStorageManager, WTF::RawPtrTraits<WebKit::OriginStorageManager>>::CheckedPtr(WebKit::OriginStorageManager*)
6   0x12426b094 WTF::CheckedPtr<WebKit::OriginStorageManager, WTF::RawPtrTraits<WebKit::OriginStorageManager>>::CheckedPtr(WebKit::OriginStorageManager*)
7   0x12426b000 WebKit::NetworkStorageManager::didIncreaseQuota(WebCore::ClientOrigin&&, WTF::ObjectIdentifierGeneric<WebKit::QuotaIncreaseRequestIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)1>, std::__1::optional<unsigned long long>)::$_23::operator()()
8   0x12426aeec WTF::Detail::CallableWrapper<WebKit::NetworkStorageManager::didIncreaseQuota(WebCore::ClientOrigin&&, WTF::ObjectIdentifierGeneric<WebKit::QuotaIncreaseRequestIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)1>, std::__1::optional<unsigned long long>)::$_23, void>::call()
9   0x11723d630 WTF::Function<void ()>::operator()() const
10  0x11735cb78 WTF::SuspendableWorkQueue::dispatch(WTF::Function<void ()>&&)::$_1::operator()() const
11  0x11735cab0 WTF::Detail::CallableWrapper<WTF::SuspendableWorkQueue::dispatch(WTF::Function<void ()>&&)::$_1, void>::call()
12  0x11723d630 WTF::Function<void ()>::operator()() const
13  0x1173dc0d0 WTF::(anonymous namespace)::DispatchWorkItem::operator()()
14  0x1173db04c void WTF::dispatchWorkItem<WTF::(anonymous namespace)::DispatchWorkItem>(void*)
15  0x18c4363e8 _dispatch_client_callout
16  0x18c43da14 _dispatch_lane_serial_drain
17  0x18c43e544 _dispatch_lane_invoke
18  0x18c4492d0 _dispatch_root_queue_drain_deferred_wlh
19  0x18c448b44 _dispatch_workloop_worker_thread
20  0x18c5e300c _pthread_wqthread
21  0x18c5e1d28 start_wqthread
com.apple.WebKit.Networking.Development terminated (pid 67709) for reason: crash
LEAK: 1 WebPageProxy


History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2FIndexedDB%2Fstorage-limit-2.https.html&test=http%2Fwpt%2Fcache-storage%2Fcache-quota-add.any.html&test=http%2Fwpt%2Fcache-storage%2Fcache-quota-after-restart.any.html&test=http%2Fwpt%2Fcache-storage%2Fcache-quota.any.html&test=http%2Fwpt%2Fcache-storage%2Fquota-third-party.https.html&test=storage%2Ffilesystemaccess%2Fsync-access-handle-storage-limit-worker.html&test=storage%2Findexeddb%2Frequest-size-estimate.html&test=http%2Ftests%2FIndexedDB%2Fstorage-limit-1.https.html&test=storage%2Findexeddb%2Fstorage-limit.html&test=storage%2Ffilesystemaccess%2Fsync-access-handle-storage-limit-worker.html&flavor=wk2&style=debug


Link:
https://ews-build.s3-us-west-2.amazonaws.com/macOS-Sonoma-Debug-WK2-Tests-EWS/e111750a-14704-clean-tree/http/wpt/cache-storage/cache-quota-after-restart.any-crash-log.txt

[Radar WebKit Bug Importer]

<rdar://problem/135910367>

[EWS]

Committed 283580@main (ed4fb66015ad): <https://commits.webkit.org/283580@main>

Reviewed commits have been landed. Closing PR #33574 and removing active labels.