Bug 27961

Summary:

bugzilla-tool land-patches needs --queue mode

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	none
Patch v1	none
Patch v1	none
Patch v1	none
Patch v1	eric: review+

Eric Seidel (no email)

Reported 2009-08-03 16:24:35 PDT

bugzilla-tool land-patches needs --queue mode Such a mode would pass --force to the patch command and --no-launch-safari Basically --queue assumes no user interaction. This is the next step towards building us a commit queue.

Attachments
Patch v1 (4.41 KB, patch) 2009-08-03 16:47 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch v1 (4.39 KB, patch) 2009-08-03 16:54 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch v1 (4.38 KB, patch) 2009-08-03 16:56 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch v1 (4.97 KB, patch) 2009-08-03 17:00 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch v1 (5.73 KB, patch) 2009-08-03 17:22 PDT, Adam Barth	eric: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-08-03 16:47:55 PDT

Created attachment 34019 [details] Patch v1

Eric Seidel (no email)

Comment 2 2009-08-03 16:52:07 PDT

Comment on attachment 34019 [details] Patch v1 get_path_from_webkit_script should be webkit_script_path I think. we don't tend to prefix getters with "get" Isn't there a ! operator in python? not options.commit_queue 318 cls.run_webkit_tests(launch_safari=not options.commit_queue) reads a little odd with "not" to my eyes. Otherwise looks good!

Adam Barth

Comment 3 2009-08-03 16:54:21 PDT

Created attachment 34021 [details] Patch v1

Adam Barth

Comment 4 2009-08-03 16:56:31 PDT

Created attachment 34022 [details] Patch v1

Eric Seidel (no email)

Comment 5 2009-08-03 16:59:31 PDT

Comment on attachment 34022 [details] Patch v1 Still looks sane.

Adam Barth

Comment 6 2009-08-03 17:00:33 PDT

Created attachment 34024 [details] Patch v1

Eric Seidel (no email)

Comment 7 2009-08-03 17:01:28 PDT

Comment on attachment 34024 [details] Patch v1 Still awesome.

Adam Barth

Comment 8 2009-08-03 17:22:31 PDT

Created attachment 34028 [details] Patch v1

Eric Seidel (no email)

Comment 9 2009-08-03 17:26:01 PDT

Comment on attachment 34028 [details] Patch v1 OK.

Adam Barth

Comment 10 2009-08-03 17:29:41 PDT

Committed revision 46739. Hard to test these changes, but hopefully I didn't break it.

Note You need to log in before you can comment on or make changes to this bug.