Bug 27961

Summary: bugzilla-tool land-patches needs --queue mode
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1
none
Patch v1
none
Patch v1
none
Patch v1
none
Patch v1 eric: review+

Description Eric Seidel (no email) 2009-08-03 16:24:35 PDT 
bugzilla-tool land-patches needs --queue mode

Such a mode would pass --force to the patch command and --no-launch-safari

Basically --queue assumes no user interaction.  This is the next step towards building us a commit queue.
Comment 1 Adam Barth 2009-08-03 16:47:55 PDT 
Created attachment 34019 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-08-03 16:52:07 PDT 
Comment on attachment 34019 [details]
Patch v1

get_path_from_webkit_script

should be webkit_script_path I think.  we don't tend to prefix getters with "get"

Isn't there a ! operator in python?
not options.commit_queue
 318                 cls.run_webkit_tests(launch_safari=not options.commit_queue)
reads a little odd with "not" to my eyes.

Otherwise looks good!
Comment 3 Adam Barth 2009-08-03 16:54:21 PDT 
Created attachment 34021 [details]
Patch v1
Comment 4 Adam Barth 2009-08-03 16:56:31 PDT 
Created attachment 34022 [details]
Patch v1
Comment 5 Eric Seidel (no email) 2009-08-03 16:59:31 PDT 
Comment on attachment 34022 [details]
Patch v1

Still looks sane.
Comment 6 Adam Barth 2009-08-03 17:00:33 PDT 
Created attachment 34024 [details]
Patch v1
Comment 7 Eric Seidel (no email) 2009-08-03 17:01:28 PDT 
Comment on attachment 34024 [details]
Patch v1

Still awesome.
Comment 8 Adam Barth 2009-08-03 17:22:31 PDT 
Created attachment 34028 [details]
Patch v1
Comment 9 Eric Seidel (no email) 2009-08-03 17:26:01 PDT 
Comment on attachment 34028 [details]
Patch v1

OK.
Comment 10 Adam Barth 2009-08-03 17:29:41 PDT 
Committed revision 46739.  Hard to test these changes, but hopefully I didn't
break it.