| Summary: | Implement HTML5 nav element | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||||||||
| Component: | DOM | Assignee: | Maciej Stachowiak <mjs> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | ||||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 32934 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 33964 [details]
slightly updated patch
Comment on attachment 33964 [details]
slightly updated patch
Without a ChangeLog it's difficult for me to know why this is correct. :( Particularly why it should have tag-priority 5.
Comment on attachment 33964 [details]
slightly updated patch
Didn't mean to flag this.
Created attachment 35096 [details]
Patch v1
Created attachment 35098 [details]
complete patch - with ChangeLog and tests
Curse you, bugzilla-tool.
Comment on attachment 35098 [details] complete patch - with ChangeLog and tests > // Checks if a string is a valid tag for the FormatBlockCommand function of execCommand. Expects lower case strings. > bool validBlockTag(const String& blockTag) > { > + // FIXME: convert this to a HashSet Eek. Or at least AtomicStrings. > + > Index: LayoutTests/fast/html/nav-element.html > =================================================================== > --- LayoutTests/fast/html/nav-element.html (revision 0) > +++ LayoutTests/fast/html/nav-element.html (revision 0) > @@ -0,0 +1,64 @@ > +<!doctype HTML> > + > +</body> > +</style> What is this </style> about. r=me Committed r47489: <http://trac.webkit.org/changeset/47489> |
Created attachment 33962 [details] Preliminary patch - no tests yet. We should implement some of the simpler new elements from HTML5. Let's start with nav.