Bug 27935

Summary:

new prototype-inheritance* tests have invalid expectations for primitive types

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

abarth, ap, oliver, sam, ukai

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
use JSVALUE64 for X86_64 LINUX, except Qt	none

Eric Seidel (no email)

Reported 2009-08-02 22:34:39 PDT

new prototype-inheritance* tests have invalid expectations for primitive types http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/resources/prototype-inheritance-2.js http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt These tests expect things like: inner.pageXOffset to have the inner prototype chain. primitive types (number, string, etc.) are wrapped using the lexical global object (according to Adam at least), so these expectations are wrong. Will fix.

Attachments
use JSVALUE64 for X86_64 LINUX, except Qt (1.05 KB, text/plain) 2009-08-03 04:25 PDT, Fumitoshi Ukai	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fumitoshi Ukai

Comment 1 2009-08-03 04:25:32 PDT

Created attachment 33968 [details] use JSVALUE64 for X86_64 LINUX, except Qt --- 2 files changed, 12 insertions(+), 1 deletions(-)

Fumitoshi Ukai

Comment 2 2009-08-03 04:27:40 PDT

sorry, wrong bug id. please ignore the attachment.

Jan Alonzo

Comment 3 2009-08-03 04:28:23 PDT

Comment on attachment 33968 [details] use JSVALUE64 for X86_64 LINUX, except Qt Clearing flag. Wrong bug.

Eric Seidel (no email)

Comment 4 2009-08-03 09:02:03 PDT

I see typeof returning: number object boolean function It seems that number and boolean should be ignored by these tests. But "function" is not a primitive type, correct? That should still have the inner global object's prototype chain, no?

Adam Barth

Comment 5 2009-08-03 10:38:50 PDT

> It seems that number and boolean should be ignored by these tests. But > "function" is not a primitive type, correct? That should still have the inner > global object's prototype chain, no? Yeah, you want "object" and "function". Keep in mind that JavaScript is tricky and typeof null === "object", so you want to filter those out as well.

Alexey Proskuryakov

Comment 6 2010-11-19 09:51:26 PST

> Will fix. Eric, please do!

Note You need to log in before you can comment on or make changes to this bug.