new prototype-inheritance* tests have invalid expectations for primitive types

• Component: Tools / Tests
• Status: NEW ---

[Eric Seidel (no email)]

new prototype-inheritance* tests have invalid expectations for primitive types
http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/resources/prototype-inheritance-2.js
http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt

These tests expect things like:

inner.pageXOffset to have the inner prototype chain.  primitive types (number, string, etc.) are wrapped using the lexical global object (according to Adam at least), so these expectations are wrong.

Will fix.

[Fumitoshi Ukai]

Created attachment 33968 [details]
use JSVALUE64 for X86_64 LINUX, except Qt


---
 2 files changed, 12 insertions(+), 1 deletions(-)

[Fumitoshi Ukai]

sorry, wrong bug id. please ignore the attachment.

[Jan Alonzo]

Comment on attachment 33968 [details]
use JSVALUE64 for X86_64 LINUX, except Qt

Clearing flag. Wrong bug.

[Eric Seidel (no email)]

I see typeof returning:
number
object
boolean
function

It seems that number and boolean should be ignored by these tests.  But "function" is not a primitive type, correct?  That should still have the inner global object's prototype chain, no?

[Adam Barth]

> It seems that number and boolean should be ignored by these tests.  But
> "function" is not a primitive type, correct?  That should still have the inner
> global object's prototype chain, no?

Yeah, you want "object" and "function".  Keep in mind that JavaScript is tricky and typeof null === "object", so you want to filter those out as well.

[Alexey Proskuryakov]

> Will fix.

Eric, please do!