Bug 279345
| Summary: | Remove Quirk shouldPreventDispatchOfTouchEvent for sites.google.com | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://sites.google.com/ | ||
| Bug Depends on: | 210143 | ||
| Bug Blocks: | |||
Karl Dubost
On Bug 210143 / rdar 58653069, a quirk has been added to make it possible to expand the submenus in sites.google.com on iPad on Safari.
Steps to reproduce:
1. With an iPad
2. Go to https://sites.google.com/
3. Choose a template
4. On the right side column, select Pages
5. A series is being displayed.
6. When hovering click on the 3 vertical dots
7. A menu appears, choose Add a subpage
8. Give it a name and create it
9. A subpage appears in the menu and a triangle at the beginning of the parent page
10. Click on the triangle icon
Result:
With Site Specific Hacks ENABLED, the triangle icon hide or show the subpages
With Site Specific Hacks DISABLED, the triangle icon is not working.
When clicking on the icon these are the events being emitted.
Site Specific Hacks ENABLED
[Log] event: touchstart, target: [object HTMLSpanElement]
[Log] event: touchstart, target: [object HTMLSpanElement]
[Log] event: mousemove, target: [object HTMLSpanElement]
[Log] event: mousemove, target: [object HTMLSpanElement]
[Log] event: mousedown, target: [object HTMLSpanElement] (x2)
[Log] event: mousedown, target: [object HTMLSpanElement]
[Log] event: mousedown, target: [object HTMLSpanElement]
[Log] event: mouseup, target: [object HTMLSpanElement] (x2)
[Log] event: mouseup, target: [object HTMLSpanElement]
[Log] event: mouseup, target: [object HTMLSpanElement]
[Log] event: click, target: [object HTMLSpanElement]
[Log] event: click, target: [object HTMLSpanElement]
[Log] event: transitionend, target: [object HTMLDivElement] (x6)
Site Specific Hacks DISABLED
[Log] event: touchstart, target: [object HTMLSpanElement]
[Log] event: touchstart, target: [object HTMLSpanElement]
[Log] event: touchend, target: [object HTMLSpanElement]
[Log] event: touchend, target: [object HTMLSpanElement]
[Log] event: transitionend, target: [object HTMLDivElement] (x6)
The code on WebKit has no call in the rest of the source code
https://github.com/search?q=repo%3AWebKit%2FWebKit+shouldPreventDispatchOfTouchEvent&type=code
It means that it requires a PR on Safari code too.
The current Quirk is acting on touchendEvent
As of today the current Quirk CAN NOT be removed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/135531665>