Bug 27923 – run-webkit-tests should not invoke "ps" repeatedly on Mac OS X

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Mark Rowe (bdash)]

run-webkit-tests invokes "ps" repeatedly in an attempt to detect whether DumpRenderTree is in the process of crashing but being kept alive while ReportCrash generates a crash log.  It's invoked in a manner that spawns a subshell, which makes things even slower.

[Mark Rowe (bdash)]

Created attachment 33939 [details]
Patch

[Sam Weinig]

Comment on attachment 33939 [details]
Patch

Looks good, one issue below.


> +++ b/WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c
> @@ -0,0 +1,17 @@
> +#include <sys/sysctl.h>
> +
> +int processIsCrashing(int pid)
> +{
> +    int mib[4] = { CTL_KERN, KERN_PROC, KERN_PROC_PID, pid };
> +    struct kinfo_proc info;
> +    size_t bufferSize = sizeof(info);
> +    if (sysctl(mib, sizeof(mib) / sizeof(mib[0]), &info, &bufferSize, 0, 0)) {
> +        perror("sysctl");
> +        return 0;
> +    }
> +
> +    struct extern_proc proc = info.kp_proc;
> +
> +    // The process is crashing if it is waiting to exit, is not a zombie, and has a non-zero exit code.
> +    return proc.p_stat != SZOMB && (proc.p_flag & P_WEXIT) && proc.p_xstat;
> +}

This file needs a license.

Otherwise, r=me.

[Mark Rowe (bdash)]

Landed in r46676.

[Mark Rowe (bdash)]

Bah, Tiger doesn't have swig.

[Mark Rowe (bdash)]

Rolled out in r46678.  Will have to do some thinking to find an approach that works on Tiger too.

[Mark Rowe (bdash)]

Created attachment 33944 [details]
With support for Tiger

[David Kilzer (:ddkilzer)]

Comment on attachment 33944 [details]
With support for Tiger

r=me

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> (From update of attachment 33944 [details])
> r=me

WebKitTools/DumpRenderTree/mac/PerlSupport/Makefile needs a license, too.

[Mark Rowe (bdash)]

Landed in r46682.