Bug 279216
| Summary: | REGRESSION(282648@main): Speedometer 3.0 test TodoMVC-JavaScript-ES6-Webpack-Complex-DOM was regressed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | DOM | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
Updating the EffectiveTextDirection needs to be optimized when inserting an Element into ancestor.
What should happen regarding the text directionality if the <body> element in a large web page has this markup <body dir="ltr">?
Currently and because of this statement in Element::insertedIntoAncestor(), we end up calling updateEffectiveTextDirection() for every Element when it is parsed and inserted in its ancestor tree.
if (UNLIKELY(selfOrPrecedingNodesAffectDirAuto() || (parent && parent->usesEffectiveTextDirection())))
updateEffectiveTextDirection();
In this scenario we do not really need to call updateEffectiveTextDirection() unless one of the descendant has the dir attribute set.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://134688490
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/33204
EWS
Committed 284731@main (799cdf9de44e): <https://commits.webkit.org/284731@main>
Reviewed commits have been landed. Closing PR #33204 and removing active labels.
EWS
Committed 283286.226@safari-7620-branch (c76d7f033d82): <https://commits.webkit.org/283286.226@safari-7620-branch>
Reviewed commits have been landed. Closing PR #1988 and removing active labels.