Bug 279191
| Summary: | [TZone] Add annotations to unannotated subclasses | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> |
| Component: | WebKit Misc. | Assignee: | Michael Saboff <msaboff> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Michael Saboff
The annotations for TZone record the size of a type so that the annotated type can be grouped with other types of the same size. A subclass that is not annotated will try to use its base class's size, that is fine if the subclass is the same size. The allocation stubs generated by the annotations handle the case where a "new" is larger than the generated stubs. This unfortunately this mismatched size case is slower than the normal path. This slow path can be improved, but adding annotations to such subclasses will always be faster.
This tracks the annotations of subclasses discovered through testing.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Saboff
<rdar://135344436>
Michael Saboff
Pull request: https://github.com/WebKit/WebKit/pull/33185
EWS
Committed 283286@main (a0f848353139): <https://commits.webkit.org/283286@main>
Reviewed commits have been landed. Closing PR #33185 and removing active labels.