Bug 279167
| Summary: | [render-blocking] Render blocking for <link> should not match elements that are on a 'stack of open elements' for the parser | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Woodrow <mattwoodrow> |
| Component: | DOM | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Matt Woodrow
https://html.spec.whatwg.org/multipage/links.html#process-internal-resource-link
Elements that are still having their children parsed should not match <link rel=expect>.
The spec also expects us to reprocess all <link rel=expect> elements each time we pop an element off the stack, which seems slow.
The matching of expect elements also depends on the document ready state. It looks like https://html.spec.whatwg.org/multipage/parsing.html#the-end:update-the-current-document-readiness expect the ready state to change before the final elements are popped, so that the reprocessing on pop would clear all remaining links. Our code appears to have already popped all elements before changing the ready state, so this won't work as-is.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/135846827>
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/38821
EWS
Committed 289020@main (fb62715ca67c): <https://commits.webkit.org/289020@main>
Reviewed commits have been landed. Closing PR #38821 and removing active labels.