Bug 279155
| Summary: | WTF::OSAllocatorPOSIX should gracefully handle guard page remap failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | commit-queue, mark.lam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 279260 | ||
| Bug Blocks: | |||
Marcus Plutowski
Currently, OSAllocatorPOSIX.cpp:tryReserveAndCommit uses `mmap` to remap the guard pages at the beginning/end of an allocation (when that allocation includes guard pages). Even though these allocations do not allocate _new_ memory per se, they can still fail — we should detect any such failures and propagate them upwards.
rdar://135306076
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/33150
EWS
Committed 283195@main (b8999f1cf051): <https://commits.webkit.org/283195@main>
Reviewed commits have been landed. Closing PR #33150 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 279260