Bug 279075
| Summary: | [WebDriver] Remove the unused ForceSoftwareCapturingViewportSnapshot option | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Qianlang Chen <qianlangchen> |
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Qianlang Chen
The patch https://github.com/WebKit/WebKit/commit/bdd0eaf1d28f834bdc3fab3e656486522f3b301f added an option ForceSoftwareCapturingViewportSnapshot to allow WebDriver to bypass a AppKit bug. Eric Carlson with a new patch https://github.com/WebKit/WebKit/pull/32687/commits/ea20b8a718cd18f88b5ba0fd7536c9f13c55f89e found a better way to fix the bug that isn't WebDriver-specific, making the option ForceSoftwareCapturingViewportSnapshot not useful anymore. We should remove it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/135208224>
Qianlang Chen
My mistake. Eric at one point had a patch that used ScreenCaptureKit to bypass the deprecated function, but that patch was never landed due to it having performance regression. His currently landed patch (https://github.com/WebKit/WebKit/pull/32687/commits/ea20b8a718cd18f88b5ba0fd7536c9f13c55f89e) still uses the deprecated function, and the ForceSoftwareCapturingViewportSnapshot parameter remains useful (not unused).
Use https://bugs.webkit.org/show_bug.cgi?id=277572 to track removing the use of the deprecated screenshotting function instead.