Bug 279068

Summary: [IFC][Cleanup] Move "logical top offset from baseline" computation to a dedicated function
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

alan
Reported 2024-09-03 09:34:11 PDT
ssia
Attachments
Patch (13.07 KB, patch)
2024-09-03 09:37 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (13.62 KB, patch)
2024-09-03 14:34 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-09-03 09:37:18 PDT
Created attachment 472423 [details] Patch
Antti Koivisto
Comment 2 2024-09-03 11:49:03 PDT
Comment on attachment 472423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472423&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:131 > +InlineLayoutUnit LineBoxVerticalAligner::logicalTopOffsetFromParentBaseline(const InlineLevelBox& inlineLevelBox, const InlineLevelBox& parentInlineBox, UseLayoutBounds useLayoutBounds) const ahhah :not_sad:
alan
Comment 3 2024-09-03 13:10:17 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 472423 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=472423&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:131 > > +InlineLayoutUnit LineBoxVerticalAligner::logicalTopOffsetFromParentBaseline(const InlineLevelBox& inlineLevelBox, const InlineLevelBox& parentInlineBox, UseLayoutBounds useLayoutBounds) const > > ahhah :not_sad: :lols:
alan
Comment 4 2024-09-03 14:34:03 PDT
Created attachment 472427 [details] [fast-cq]Patch
EWS
Comment 5 2024-09-03 15:14:53 PDT
Committed 283117@main (960090f6f626): <https://commits.webkit.org/283117@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472427 [details].
Radar WebKit Bug Importer
Comment 6 2024-09-03 15:15:22 PDT
<rdar://problem/135226896>
Note You need to log in before you can comment on or make changes to this bug.