Bug 279062

Summary: [IFC][Cleanup] Unify inline-level box top offset computation in LineBoxVerticalAligner
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

zalan
Reported 2024-09-03 08:46:21 PDT
ssia
Attachments
Patch (13.03 KB, patch)
2024-09-03 08:52 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (13.13 KB, patch)
2024-09-03 13:05 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2024-09-03 08:52:53 PDT
Created attachment 472420 [details] Patch
Antti Koivisto
Comment 2 2024-09-03 11:47:59 PDT
Comment on attachment 472420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472420&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:174 > + auto topOffsetFromParentBaseline = InlineLayoutUnit { }; > switch (verticalAlign.type) { no lambda :sad:
zalan
Comment 3 2024-09-03 13:05:01 PDT
Created attachment 472426 [details] [fast-cq]Patch
EWS
Comment 4 2024-09-03 14:33:35 PDT
Committed 283114@main (633f43928a37): <https://commits.webkit.org/283114@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472426 [details].
Radar WebKit Bug Importer
Comment 5 2024-09-03 14:34:31 PDT
<rdar://problem/135224379>
Note You need to log in before you can comment on or make changes to this bug.