Bug 279049

Summary:

counter-style doesn't render RTL text correctly

Product:

WebKit

Reporter:

Ebrahim Byagowi <ebrahim>

Component:

Text

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, fantasai.bugs, karlcow, koivisto, mmaxfield, simon.fraser, vitor.roriz, webkit-bug-importer, zalan

Priority:

Keywords:

BrowserCompat, InRadar

Version:

Safari 17

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Safari vs Chrome and Firefox	none
Patch	none
Patch	none
[fast-cq]Patch	none

Ebrahim Byagowi

Reported 2024-09-02 23:47:24 PDT

Created attachment 472412 [details] Safari vs Chrome and Firefox Discovered this in a Wikipedia page Compare the following with Chrome and Firefox data:text/html,<style>@counter-style%20persian-alpha{symbols:"\627\644\641";}</style><li style="list-style-type:persian-alpha"> Expected: All be same Actual: Safari renders the text from end

Attachments
Safari vs Chrome and Firefox (86.62 KB, image/png) 2024-09-02 23:47 PDT, Ebrahim Byagowi	no flags	Details
Patch (3.38 KB, patch) 2024-09-03 18:46 PDT, alan	no flags	Details Formatted Diff Diff
Patch (2.65 KB, patch) 2024-09-03 19:10 PDT, alan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (4.01 KB, patch) 2024-09-04 11:25 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2024-09-03 18:46:27 PDT

Created attachment 472431 [details] Patch

alan

Comment 2 2024-09-03 18:48:16 PDT

Thank you for filing this bug! WebKit's bidi test coverage seems to be lacking. :(

alan

Comment 3 2024-09-03 19:10:03 PDT

Created attachment 472432 [details] Patch

Ebrahim Byagowi

Comment 4 2024-09-03 21:22:10 PDT

This context.drawText seems like a bad API, I wish other uses of it also get reviewed or it's deprecated so no other uses of it be added in the future.

alan

Comment 5 2024-09-04 11:25:52 PDT

Created attachment 472449 [details] [fast-cq]Patch

alan

Comment 6 2024-09-04 11:27:40 PDT

(In reply to Ebrahim Byagowi from comment #4) > This context.drawText seems like a bad API, I wish other uses of it also get > reviewed or it's deprecated so no other uses of it be added in the future. Yeah I completely agree...but apparently RenderListMarker is doing some bidi on its own so the final change is slightly different from what I originally thought it was gonna be.

EWS

Comment 7 2024-09-05 05:09:29 PDT

Committed 283200@main (38e7da4752e5): <https://commits.webkit.org/283200@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472449 [details].

Radar WebKit Bug Importer

Comment 8 2024-09-05 05:10:15 PDT

<rdar://problem/135338476>

Note You need to log in before you can comment on or make changes to this bug.