Bug 278853
| Summary: | [build.webkit.org] [GTK] Switch GTK4 bot to GTK3 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | WebKitGTK | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, philn |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=282842 | ||
Diego Pino
Right now, all GTK bots (EWS and post-commit bots) build and run tests using GTK3. There is also one bot that builds and runs tests using GTK4: [GTK-Linux-64-bit-Release-GTK4-Tests](https://build.webkit.org/#/builders/9).
We would like to switch all bots to GTK4, since now the state of layout tests under GTK4 is in good shape. This change doesn't require modifying WebKit codebase, simply to change a setting inside the bots. As for the current post-commit GTK4 bot, we would like to switch it to GTK3. For this change, it's necessary to modify WebKit codebase.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/32885
EWS
Committed 283056@main (736fca8d5714): <https://commits.webkit.org/283056@main>
Reviewed commits have been landed. Closing PR #32885 and removing active labels.
Diego Pino
https://build.webkit.org has been rebooted and the change is now operative. However, it seems all tests in this bot are failing. The reason is the bot was configured with:
```
"additionalArguments": ["--cmakeargs=-DUSE_GTK4=OFF"]
```
Parameter 'additionalArguments' is passed not only in the build step, but in all test steps, causing the tests to fail since the argument is unknown to the scripts running tests. For instance:
https://build.webkit.org/#/builders/1157/builds/45/steps/21/logs/stdio
```
python3 Tools/Scripts/run-gtk-tests --release --cmakeargs=-DUSE_GTK4=OFF
Usage: run-gtk-tests [options] [test...]
run-gtk-tests: error: no such option: --cmakeargs
```
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/33541
EWS
Committed 283551@main (43c5e3445282): <https://commits.webkit.org/283551@main>
Reviewed commits have been landed. Closing PR #33541 and removing active labels.
Philippe Normand
I think this broke WebKitGTK4 uploads for GNOME Web Canary purposes.
We need a GTK4 (flatpak) bot that has a ArchiveBuiltProduct step...
Philippe Normand
(In reply to Philippe Normand from comment #6)
> I think this broke WebKitGTK4 uploads for GNOME Web Canary purposes.
>
> We need a GTK4 (flatpak) bot that has a ArchiveBuiltProduct step...
and UploadBuiltProduct.