Bug 278804
| Summary: | [WebDriver][GLIB] Segfault with connection being closed by empty SetTargetList not related to disconnection | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
When initializing a session, might an empty target list in `SessionHostGlib.cpp::setTargetList()`. After 282489@main / bug277341, this function assumes whenever we get an empty target list, it means we lost connection to the RemoteInspectorServer. But we might get empty lists due to the message handler filtering only the "Automation" targets before sending to `setTargetList()`, removing targets like `WebPage`.
This behavior is leading to segfaults inside `setTargetList` due to the scenario above prematurely calling `connectionDidClose()`.
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/32951
EWS
Committed 283061@main (b00d19a0d891): <https://commits.webkit.org/283061@main>
Reviewed commits have been landed. Closing PR #32951 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/135147545>