Bug 278785
| Summary: | REGRESSION(281966@main): [Win] `PageClient::didPerformDragOperation()` is never called | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vitaly Dyackhov <vitaly> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vitaly Dyackhov
Before 281966@main
```
void WebPageProxy::performDragOperation(DragData& dragData, const String& dragStorageName, SandboxExtension::Handle&& sandboxExtensionHandle, Vector<SandboxExtension::Handle>&& sandboxExtensionsForUpload)
{
#if PLATFORM(COCOA)
grantAccessToCurrentPasteboardData(dragStorageName);
#endif
#if PLATFORM(GTK)
performDragControllerAction(DragControllerAction::PerformDragOperation, dragData);
#else
if (!hasRunningProcess())
return;
sendWithAsyncReply(Messages::WebPage::PerformDragOperation(dragData, WTFMove(sandboxExtensionHandle), WTFMove(sandboxExtensionsForUpload)), [this, protectedThis = Ref { *this }] (bool handled) {
protectedPageClient()->didPerformDragOperation(handled);
});
#endif
}
```
after
```
void WebPageProxy::performDragOperation(DragData& dragData, const String& dragStorageName, SandboxExtension::Handle&& sandboxExtensionHandle, Vector<SandboxExtension::Handle>&& sandboxExtensionsForUpload)
{
#if PLATFORM(GTK)
performDragControllerAction(DragControllerAction::PerformDragOperation, dragData);
#endif
#if PLATFORM(COCOA)
if (!hasRunningProcess())
return;
grantAccessToCurrentPasteboardData(dragStorageName, [this, protectedThis = Ref { *this }, dragStorageName, dragData = WTFMove(dragData), sandboxExtensionHandle = WTFMove(sandboxExtensionHandle), sandboxExtensionsForUpload = WTFMove(sandboxExtensionsForUpload)] () mutable {
sendWithAsyncReply(Messages::WebPage::PerformDragOperation(dragData, WTFMove(sandboxExtensionHandle), WTFMove(sandboxExtensionsForUpload)), [this, protectedThis = Ref { *this }] (bool handled) {
protectedPageClient()->didPerformDragOperation(handled);
});
});
#endif
}
```
Note missing #else directive.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Vitaly Dyackhov
Pull request: https://github.com/WebKit/WebKit/pull/32822
EWS
Committed 283050@main (b9af02f5af3f): <https://commits.webkit.org/283050@main>
Reviewed commits have been landed. Closing PR #32822 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/135130132>