Bug 278726
| Summary: | [MSE][GStreamer] Support markEndOfStream() before appendBuffer() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> |
| Component: | Media | Assignee: | Enrique Ocaña <eocanha> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Enrique Ocaña
WebKit MSE can't complete playback when JavaScript performs MediaSource.markEndOfStream() before appending any samples with SourceBuffer.appendBuffer().
That's on the current GStreamer version used in the test bots (gst 1.24). On older GStreamer versions (eg: 1.18.6), parsebin (from the playback pipeline) emits an unrecoverable error as well.
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/1366
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Enrique Ocaña
Pull request: https://github.com/WebKit/WebKit/pull/32768
EWS
Committed 282958@main (a1d1ac683b44): <https://commits.webkit.org/282958@main>
Reviewed commits have been landed. Closing PR #32768 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/135006772>
Enrique Ocaña
This issue has reappeared downstream (wpe-2.46, GStreamer 1.18) and also has been reproduced upstream when the test case is exercised in a loop and the race condition of an error occurs while errors are ignored, but the GstMessage with the error takes a moment to propagate to the main thread (when the errors are no longer ignored).
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/1558
Enrique Ocaña
Pull request: https://github.com/WebKit/WebKit/pull/51211
EWS
Committed 300605@main (b1ff5913b211): <https://commits.webkit.org/300605@main>
Reviewed commits have been landed. Closing PR #51211 and removing active labels.