Bug 278606
| Summary: | Remove the unused unrenderable inner border code in BorderPainter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=252092 https://bugs.webkit.org/show_bug.cgi?id=244638 |
||
Simon Fraser (smfr)
After 256943@main, the code that checks if the inner border is unrenderable in BorderPainter is unused, because the radii are fixed in in RenderStyle::getRoundedInnerBorderFor(). This code doesn't work very well anyway, so remove it.
In future, we need to do fancier path-based clipping to make these kinds of borders look good.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/134624276>
Simon Fraser (smfr)
Pull request: https://github.com/WebKit/WebKit/pull/32670
EWS
Committed 282705@main (b133daba3fe5): <https://commits.webkit.org/282705@main>
Reviewed commits have been landed. Closing PR #32670 and removing active labels.