Bug 278597

Summary:	Rename WebPageProxy and LocalFrameLoaderClient functions to be less ambiguous
Product:	WebKit	Reporter:	Ryan Reno <rreno>
Component:	Page Loading	Assignee:	Ryan Reno <rreno>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	beidson, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Ryan Reno

Reported 2024-08-23 20:01:10 PDT

didSameDocumentNavigationForFrameViaJSHistoryAPI might be parsed as "did same document navigation for 'JS History API'" when in fact it means "did same document navigation for 'JS' OR 'JS History API'". I propose we rename this function and IPC messages to be more clear.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-08-23 20:01:31 PDT

<rdar://problem/134603009>

Ryan Reno

Comment 2 2024-08-23 20:05:43 PDT

Pull request: https://github.com/WebKit/WebKit/pull/32662

EWS

Comment 3 2024-09-13 08:32:33 PDT

Committed 283623@main (8972ce9795a8): <https://commits.webkit.org/283623@main> Reviewed commits have been landed. Closing PR #32662 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.