Bug 278522
| Summary: | RELEASE_ASSERT that ObjectIdentifier is valid when constructed from a raw value | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
We recently made it so that ObjectIdentifier no longer has a default constructor or an "invalid" state. However, a call site could still in theory construct an ObjectIdentifier with a raw value of 0 to construct an invalid identifier. Doing so would only hit an assertion in debug builds. For hardening, I'm suggesting we turn this debug assertion into a release one. This tested as performance neutral.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/32590
EWS
Committed 282646@main (576330780972): <https://commits.webkit.org/282646@main>
Reviewed commits have been landed. Closing PR #32590 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/134545098>