Bug 278499
| Summary: | [Grid] Some intrinsic sizing for grid item methods incorrectly named in GridTrackSizingAlgorithm | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sammy Gill
GridTrackSizingAlgorithm defines minContentForGridItem, maxContentForGridItem, and minSizeForGridItem to represent the min content contribution, max content contribution, and minimum contributions, respectively. We should rename these to properly represent the spec terms as currently they can be misleading in certain contexts. For example, the min content size of a grid item is different min content contribution as the former does not consider the minimum size property while the latter does.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/134451435>
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/32561
EWS
Committed 282643@main (51781e32c383): <https://commits.webkit.org/282643@main>
Reviewed commits have been landed. Closing PR #32561 and removing active labels.