Bug 278475
| Summary: | Web Inspector: JavaScriptCore - error: member access into incomplete type 'Inspector::RemoteConnectionToTarget' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Qianlang Chen <qianlangchen> |
| Component: | Web Inspector | Assignee: | Qianlang Chen <qianlangchen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Qianlang Chen
C++20 and C++23 make implicit destructors constexpr when possible, and compiler changes make this happen in more cases. This causes a few objects to be instantiated more eagerly which is causing template instantiation failures.
We likely need to avoid forward-declaring some types in this case, or explicitly define the destructors out-of-line to avoid the implicit destructor being instantiated too early.
LLVM PR which contains some discussion on the C++ standard changes that cause this failure: https://github.com/llvm/llvm-project/pull/77753
rdar://134288008
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Qianlang Chen
Pull request: https://github.com/WebKit/WebKit/pull/32539
EWS
Committed 282663@main (7e42319448fe): <https://commits.webkit.org/282663@main>
Reviewed commits have been landed. Closing PR #32539 and removing active labels.