Bug 27845

Summary: document.compatMode is incorrect for javascript: protocol URLs in IFRAMEs
Product: WebKit Reporter: haysfamily
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, commit-queue, marcoos+bwo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
tiny HTML file that shows the correct compatMode with no DOCTYPE in the main document, and then incorrectly set for the IFRAME
none
Patch none

haysfamily
Reported 2009-07-30 11:50:38 PDT
Created attachment 33797 [details] tiny HTML file that shows the correct compatMode with no DOCTYPE in the main document, and then incorrectly set for the IFRAME When you specify a src="javascript:'<HTML><BODY></BODY></HTML>'" attribute for an IFRAME, WebKit assigns document.compatMode = CSS1Compat (strict) even though no DOCTYPE was specified. All other browsers tested (IE 6, 7, 8, Firefox 2, 3, 3.5, Opera 9.6x) report the compatMode = BackCompat (quirks).
Attachments
tiny HTML file that shows the correct compatMode with no DOCTYPE in the main document, and then incorrectly set for the IFRAME (503 bytes, text/html)
2009-07-30 11:50 PDT, haysfamily 		no flags
Details
Patch (1.63 KB, patch)
2011-03-10 12:33 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Marek Stepien
Comment 1 2011-03-10 06:37:08 PST
This does not happen in recent WebKit nightlies and Chrome 10. It is reproducible on Safari 5, though (I only checked on Windows).
Alexey Proskuryakov
Comment 2 2011-03-10 10:52:27 PST
Fixed by HTML5 parser? Do we need a regression test?
Adam Barth
Comment 3 2011-03-10 11:28:19 PST
I'll write a test.
Adam Barth
Comment 4 2011-03-10 12:33:35 PST
Created attachment 85370 [details] Patch
Alexey Proskuryakov
Comment 5 2011-03-10 12:42:30 PST
Comment on attachment 85370 [details] Patch It's better when tests mention what expected results are, and why (a link to a bug would be nice). That makes it much easier to decide what to do when results unexpectedly change.
WebKit Commit Bot
Comment 6 2011-03-10 23:24:31 PST
Comment on attachment 85370 [details] Patch Clearing flags on attachment: 85370 Committed r80821: <http://trac.webkit.org/changeset/80821>
WebKit Commit Bot
Comment 7 2011-03-10 23:24:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.