Bug 278387

Summary:	[WebAuthn] Fix -Wmissing-designated-field-initializers issues in CtapRequestTest.cpp
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	Tools / Tests	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

David Kilzer (:ddkilzer)

Reported 2024-08-20 09:26:04 PDT

[WebAuthn] Fix -Wmissing-designated-field-initializers issues in CtapRequestTest.cpp. Example warnings: Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:243:9: error: missing field 'read' initializer [-Werror,-Wmissing-designated-field-initializers] 243 | } | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:244:5: error: missing field 'appid' initializer [-Werror,-Wmissing-designated-field-initializers] 244 | }; | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:272:9: error: missing field 'read' initializer [-Werror,-Wmissing-designated-field-initializers] 272 | } | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:273:5: error: missing field 'appid' initializer [-Werror,-Wmissing-designated-field-initializers] 273 | }; | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:489:9: error: missing field 'support' initializer [-Werror,-Wmissing-designated-field-initializers] 489 | } | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:490:5: error: missing field 'appid' initializer [-Werror,-Wmissing-designated-field-initializers] 490 | }; | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:532:9: error: missing field 'support' initializer [-Werror,-Wmissing-designated-field-initializers] 532 | } | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:533:5: error: missing field 'appid' initializer [-Werror,-Wmissing-designated-field-initializers] 533 | }; | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:579:9: error: missing field 'support' initializer [-Werror,-Wmissing-designated-field-initializers] 579 | } | ^ Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:580:5: error: missing field 'appid' initializer [-Werror,-Wmissing-designated-field-initializers] 580 | }; | ^ 10 errors generated.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-08-20 09:27:59 PDT

<rdar://problem/134349142>

David Kilzer (:ddkilzer)

Comment 2 2024-08-20 09:30:51 PDT

Pull request: https://github.com/WebKit/WebKit/pull/32459

David Kilzer (:ddkilzer)

Comment 3 2024-08-20 16:14:27 PDT

Committed 282519@main (bb53aa3): https://commits.webkit.org/282519@main Reviewed commits have been landed. Closing PR #32459 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.