Summary: | [Chromium] Functions Keys don't work in google spreadsheet. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hironori Bono <hbono> | ||||||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, eric, estade, evan, levin | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | Linux | ||||||||||||||
Attachments: |
|
Description
Hironori Bono
2009-07-30 00:19:12 PDT
Created attachment 33871 [details]
A quick fix
The attached layout test fails on platforms whose eventSender.keyDown() cannot send function-key events.
I'm wondering which is the better option: moving this layout test to "LayoutTest/platform" or changing "Skipped" files?
Comment on attachment 33871 [details]
A quick fix
Woh woh. Please end the copy-pasted insanity in DumpRenderTree.
Created attachment 34443 [details]
The second quick fix
Thank you for your review and sorry for my slow update.
I updated EventSendingController.mm to avoid copy-and-pastes. Also, this change moves the new layout test to "platform/mac" because I don't have any development environment of WebKit except Mac, i.e. I can verify this test works only on Mac (Leopard).
Regards,
Created attachment 34444 [details]
The third quick fix.
Sorry, I attached a wrong patch.
Comment on attachment 34444 [details]
The third quick fix.
Looks fine. Except the results should not be in platform/mac, but rather right next to the test. At least I don't think this test is platform specific, is it?
Created attachment 34721 [details]
The fourth quick fix
Thank you for your review and comments.
I have moved the new layout test "keydown-function-keys.html" from "LayoutTests/platform/mac/fast/event" to "LayoutTests/fast/event". Also, I added this test to "LayoutTests/platform/{gtk,qt,win}/Skipped" files because eventSender.keyDown() cannot send function-key events on the platforms. (I don't have any idea how to support them since I don't have build environments for these platforms.)
Comment on attachment 34721 [details]
The fourth quick fix
I would have just inlined the "runScript()" stuff in the second script tag. :) But this looks totally fine as is.
Comment on attachment 34721 [details] The fourth quick fix Rejecting patch 34721 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34721 from bug 27827 failed to download and apply. patching file LayoutTests/platform/gtk/Skipped Hunk #1 FAILED at 5979. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej patch -p0 "LayoutTests/platform/gtk/Skipped" returned 1. Pass --force to ignore patch failures. Ping. Who needs to do something here? Looks like either someone needs to update the patch so it applies cleanly to TOT or some need to land this manually. Created attachment 38522 [details]
The fifth quick fix
I have updated this change to fix a conflict in "LayoutTests/platform/gtk/Skipped" and move the code in runScript() into the second <script> element.
I wish this fix can be landed without conflicts.
Comment on attachment 38522 [details]
The fifth quick fix
Forwarding Eric's review+ to the updated patch.
Comment on attachment 38522 [details] The fifth quick fix Clearing flags on attachment: 38522 Committed r47741: <http://trac.webkit.org/changeset/47741> All reviewed patches have been landed. Closing bug. |