Bug 278233
Summary: | imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker.html?wss is flakey failure on iOS Sim | ||
---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | annevk, gsnedders, Hironori.Fujii, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=278588 https://bugs.webkit.org/show_bug.cgi?id=276764 |
David Kilzer (:ddkilzer)
Summary:
imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker.html?wss is flakey failure on iOS Simulator
PR: <https://github.com/WebKit/WebKit/pull/32275>
Test run: <https://ews-build.webkit.org/#/builders/42/builds/35920>
Test results #1: <https://ews-build.s3-us-west-2.amazonaws.com/iOS-17-Simulator-WPT-WK2-Tests-EWS/e3d382f7-35920/results.html>
Test results #2: <https://ews-build.s3-us-west-2.amazonaws.com/iOS-17-Simulator-WPT-WK2-Tests-EWS/e3d382f7-35920-rerun/results.html>
History (iOS only): <https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebsockets%2Fbasic-auth.any.sharedworker.html%3Fwss&platform=ios>
Diff:
--- /Volumes/Data/worker/iOS-17-Simulator-WPT-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker_wss-expected.txt
+++ /Volumes/Data/worker/iOS-17-Simulator-WPT-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker_wss-actual.txt
@@ -1,3 +1,3 @@
-PASS HTTP basic authentication should work with WebSockets
+FAIL HTTP basic authentication should work with WebSockets assert_unreached: open should succeed Reached unreachable code
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/134059632>
David Kilzer (:ddkilzer)
Current expectations (as of 281902@main):
$ grep -r basic-auth.any.sharedworker.html LayoutTests
LayoutTests/TestExpectations:imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker.html?wpt_flags=h2 [ Skip ]
LayoutTests/platform/glib/TestExpectations:webkit.org/b/264805 imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker.html?wss [ Failure ]
LayoutTests/platform/mac-wk1/TestExpectations:imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker.html?wss [ Pass Failure ]
David Kilzer (:ddkilzer)
Oh, is this the issue?
LayoutTests/TestExpectations:imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker.html?wpt_flags=h2 [ Skip ]
Should "wpt_flags=h2" be "wss" like the other two expectations?
I don't know what the significance of the query parameters is for these tests.
Anne van Kesteren
Adding Sam who has been investigating H/2 WebSockets WPT issues.
Sam Sneddon [:gsnedders]
(In reply to David Kilzer (:ddkilzer) from comment #3)
> Oh, is this the issue?
>
> LayoutTests/TestExpectations:imported/w3c/web-platform-tests/websockets/
> basic-auth.any.sharedworker.html?wpt_flags=h2 [ Skip ]
>
> Should "wpt_flags=h2" be "wss" like the other two expectations?
>
> I don't know what the significance of the query parameters is for these
> tests.
We run the same tests against an H1 and an H2 server.
That we skip the H2 case (with ?wpt_flags=h2) is expected for Apple ports (we don't support connecting to WebSockets over HTTP/2).
The H1 case should work, and this is probably genuine flakiness? I wouldn't be surprised if the underlying cause is within CFNetwork, however.
EWS
Test gardening commit 282627@main (7408abd3fdee): <https://commits.webkit.org/282627@main>
Reviewed commits have been landed. Closing PR #32600 and removing active labels.
EWS
Test gardening commit 282805@main (cf26f601d015): <https://commits.webkit.org/282805@main>
Reviewed commits have been landed. Closing PR #32772 and removing active labels.
Fujii Hironori
284268@main reverted 280750@main. Closed.
*** This bug has been marked as a duplicate of bug 275992 ***