Bug 27823

Summary: Remove XBM support
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: ImagesAssignee: Peter Kasting <pkasting>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch v1
sam: review-
patch v2 dglazkov: review+

Peter Kasting
Reported 2009-07-29 17:43:57 PDT
Mozilla has removed XBM support on https://bugzilla.mozilla.org/show_bug.cgi?id=504822 , and noted that IE removed it in IE6. We might as well rip it out too (at least in the cross-platform image decoders). Added bonus: this will obsolete bug 26527.
Attachments
patch v1 (15.29 KB, patch)
2010-01-11 11:23 PST, Peter Kasting 		sam: review-
DetailsFormatted DiffDiff
patch v2 (19.93 KB, patch)
2010-01-11 12:48 PST, Peter Kasting 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Kasting
Comment 1 2010-01-11 11:23:09 PST
Created attachment 46292 [details] patch v1
Sam Weinig
Comment 2 2010-01-11 11:41:35 PST
Comment on attachment 46292 [details] patch v1 This will break some builds. You need to update the build-system files.
Peter Kasting
Comment 3 2010-01-11 11:42:41 PST
Oh yeah. Good catch. (I feel silly now.)
Peter Kasting
Comment 4 2010-01-11 12:48:27 PST
Created attachment 46301 [details] patch v2 Now with more build file fixup.
Dimitri Glazkov (Google)
Comment 5 2010-01-12 11:33:11 PST
Comment on attachment 46301 [details] patch v2 Looks like apply-patch can't handle rm dirs? rs=me. Good luck landing :)
Peter Kasting
Comment 6 2010-01-12 11:53:13 PST
Landed in r53152.
Note You need to log in before you can comment on or make changes to this bug.