Bug 278218
| Summary: | [css-anchor-position-1] Refactor style & layout interleaving for anchor positioning | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Choi <david_choi5> |
| Component: | CSS | Assignee: | David Choi <david_choi5> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Choi
The current `AnchorPositionedState` uses booleans to represent stages of the
anchor-positioned element resolution process. This uses more space than
necessary while introducing the potential for bugs via inconsistent combinations
of boolean states.
Style::TreeResolver also houses static functions and class methods related to
anchor positioning that really should be moved to AnchorPositionEvaluator.
We should refactor the code to address these concerns.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/134015009>
David Choi
Pull request: https://github.com/WebKit/WebKit/pull/32289
EWS
Committed 282349@main (f13cf97dc576): <https://commits.webkit.org/282349@main>
Reviewed commits have been landed. Closing PR #32289 and removing active labels.