Bug 27819

Summary: [commit+] Need to update layout test for different timings of multi process message ports
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, atwilson, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch
none
fixed bad merge
eric: review+
removed setTimeout none

John Abd-El-Malek
Reported 2009-07-29 16:12:18 PDT
With multi-process message ports, a message isn't delivered before a setTimeout(, 0) can execute. This breaks an assumptions in message-channel-gc.html.
Attachments
Proposed patch (1.61 KB, patch)
2009-07-29 16:14 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
fixed bad merge (1.87 KB, patch)
2009-07-29 16:18 PDT, John Abd-El-Malek 		eric: review+
DetailsFormatted DiffDiff
removed setTimeout (1.82 KB, patch)
2009-07-29 16:40 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2009-07-29 16:14:43 PDT
Created attachment 33748 [details] Proposed patch
John Abd-El-Malek
Comment 2 2009-07-29 16:18:29 PDT
Created attachment 33749 [details] fixed bad merge
Eric Seidel (no email)
Comment 3 2009-07-29 16:33:18 PDT
Comment on attachment 33749 [details] fixed bad merge Why the set-timeout for the "done"? Looks fine otherwise.
John Abd-El-Malek
Comment 4 2009-07-29 16:40:42 PDT
Created attachment 33752 [details] removed setTimeout Thanks for the quick review. You're right, no need. Updated patch.
Eric Seidel (no email)
Comment 5 2009-07-29 16:41:22 PDT
Comment on attachment 33752 [details] removed setTimeout LGTM.
John Abd-El-Malek
Comment 6 2009-07-29 17:55:21 PDT
If someone can commit this for me, that'd be great. Thanks.
Adam Barth
Comment 7 2009-08-01 10:58:19 PDT
Comment on attachment 33752 [details] removed setTimeout Clearing review flag on attachment: 33752 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/events/message-channel-gc.html Committed r46673 M LayoutTests/ChangeLog M LayoutTests/fast/events/message-channel-gc.html r46673 = db4c3d1baaf0fa69e2af6d2d0516de6ca68f0cf7 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46673
Adam Barth
Comment 8 2009-08-01 10:58:24 PDT
All reviewed patches have been landed. Closing bug.
John Abd-El-Malek
Comment 9 2009-08-03 06:26:33 PDT
(In reply to comment #8) > All reviewed patches have been landed. Closing bug. Thanks!
Note You need to log in before you can comment on or make changes to this bug.