Bug 278073
| Summary: | [WebKitLegacy] Fix -Wenum-compare in WebDefaultPolicyDelegate.m | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 201596 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Fix -Wenum-compare in WebDefaultPolicyDelegate.m from WebKitLegacy when compiling with newer clang:
OpenSource/Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultPolicyDelegate.m:88:24: error: comparison of different enumeration types ('WebNavigationType' (aka 'enum WebNavigationType') and 'WebExtraNavigationType') [-Werror,-Wenum-compare]
88 | } else if (navType == WebNavigationTypePlugInRequest) {
| ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133809285>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/32164
David Kilzer (:ddkilzer)
Committed 282241@main (a27fb4b): https://commits.webkit.org/282241@main
Reviewed commits have been landed. Closing PR #32164 and removing active labels.