Summary: | Don't export WebPluginController.h as a private header | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, mrowe | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Is WebPluginController.h even used outside of WebKit? If not, a better fix would be to remove it from the private headers. Since the include in WebPluginController.h has been like this since April I'd would have expected that we would have noticed that this header wasn't usable as-is. (In reply to comment #1) > Is WebPluginController.h even used outside of WebKit? If not, a better fix > would be to remove it from the private headers. Since the include in > WebPluginController.h has been like this since April I'd would have expected > that we would have noticed that this header wasn't usable as-is. Yes, +[WebPluginController plugInViewWithArguments:fromPluginPackage:] is being used outside of WebKit on iPhone OS. (In reply to comment #1) > Is WebPluginController.h even used outside of WebKit? If not, a better fix > would be to remove it from the private headers. Since the include in > WebPluginController.h has been like this since April I'd would have expected > that we would have noticed that this header wasn't usable as-is. WebPluginController.h has been a private header since r9857 (July 21, 2005). http://trac.webkit.org/changeset/9857 However, I can't find any uses of it outside WebKit. (In reply to comment #3) > However, I can't find any uses of it outside WebKit. On Mac OS X. Created attachment 33740 [details]
Patch v2
Fixed in r46565. <http://trac.webkit.org/changset/46565> |
Created attachment 33684 [details] Patch v1 Reviewed by NOBODY (OOPS!). WebPluginContainerCheck.h must be a private header because it is included from WebPluginController.h, which is a private header. WebKit: * WebKit.xcodeproj/project.pbxproj: Export WebPluginContainerCheck.h as a private header. WebKit/mac: * Plugins/WebPluginController.h: Changed #import of WebPluginContainerCheck.h to use a framework-style path. --- 4 files changed, 26 insertions(+), 2 deletions(-)