Bug 277862

Summary: [Text Directionality] Fix directionality for shadow tree
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: DOMAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=278698
Attachments:
Description Flags
test case none

Attachments
test case (1.26 KB, text/html)
2024-08-09 12:33 PDT, Said Abou-Hallawa 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-08-09 10:10:50 PDT
<rdar://problem/133549820>
Said Abou-Hallawa
Comment 2 2024-08-09 12:33:00 PDT
Created attachment 472104 [details] test case I am attaching a test case. It contains two host <div> elements. Both hosts have <p> elements with Arabic text and undefined dir property. We insert a `<slot dir="auto"></slot>` in the shadow tree of the first <div> host. This will add the first child of this host as a slotted element to `<slot>` element which is the <p> element. According to the specs if the dir property is "undefined": Return the parent directionality of element. So I am not sure what the parent of the first <p> should be. Should it be its host <div> which also has undefined dir property? Or should it be the <slot> element which has dir="auto"?
Said Abou-Hallawa
Comment 3 2024-08-20 13:39:52 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32482
EWS
Comment 4 2024-08-22 21:16:23 PDT
Committed 282648@main (b6ee5d981582): <https://commits.webkit.org/282648@main> Reviewed commits have been landed. Closing PR #32482 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.