Bug 27778 – Add more DOM Storage tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Jeremy Orlow]

Add more tests.

[Jeremy Orlow]

Created attachment 33667 [details]
v1

Add more localStorage tests.  As with before, once I know everything's OK with them, I'll port them over to SessionStorage tests as well.

       These test behavior that I don't think was very well verified earlier.

        * storage/domstorage/localstorage/complex-keys-expected.txt: Added.
        * storage/domstorage/localstorage/complex-keys.html: Added.
              A bunch of corner cases related to keys.
        * storage/domstorage/localstorage/complex-values-expected.txt: Added.
        * storage/domstorage/localstorage/complex-values.html: Added.
              A bunch of corner cases related to values.
        * storage/domstorage/localstorage/remove-item-expected.txt: Added.
        * storage/domstorage/localstorage/remove-item.html: Added.
              Test basic removeItem functionality.

[Jeremy Orlow]

It'd be great if someone could look at this.

[Adam Barth]

Comment on attachment 33667 [details]
v1

I support all non-flaky tests.  :)

[David Levin]

Adam gave you an r+ but I think the tests should be fixed in the following manner:

I noticed that the test don't tell me anything so that I know if they've passed or not when I run them in a browser.

Typically each (sub) test case prints "PASS" when it passes or "FAIL" if it doesn't (both of which would be followed by the type of information you print out currently).

Also at the end of all testing in a layout test, it prints done.

There should usually be a message at the top of the test that indicates this is what will happen. ( blah blah blah. This test should print PASS a number of times followed by DONE)

Lastly, there is a little test framework that helps you with this and work really well for you since you don't need any particular tags.  (See the "how to" tab in https://spreadsheets.google.com/ccc?key=0Ap59kAXVHrP7cGlHa1VVTUxXLVBOVXp1aFRDem00TlE&hl=en).

[Jeremy Orlow]

I talked to Dave about this.  None of the other DOM Storage tests currently do this and it'll require a fair amount of work to convert all of these tests, so I'm going commit this as is and create a bug against myself to some cleanup passes on all the tests there in the near future.

[Jeremy Orlow]

Sending        LayoutTests/ChangeLog
Adding         LayoutTests/storage/domstorage/localstorage/complex-keys-expected.txt
Adding         LayoutTests/storage/domstorage/localstorage/complex-keys.html
Adding         LayoutTests/storage/domstorage/localstorage/complex-values-expected.txt
Adding         LayoutTests/storage/domstorage/localstorage/complex-values.html
Adding         LayoutTests/storage/domstorage/localstorage/remove-item-expected.txt
Adding         LayoutTests/storage/domstorage/localstorage/remove-item.html
Transmitting file data .......
Committed revision 46639.
http://trac.webkit.org/changeset/46639