Bug 27774 – [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Antonio Gomes]

Created attachment 33656 [details]
v0.1 - code style fixes + removal of unneeded includes 

these files have coding style issues (accordingly to WebCore/Scripts/modules/cpplint.py). patch fixes them, and remove some unneeded includes (e.g. gdk.h or gtk.h).

ps: this patch make gtk video backend work for EFL out of the box too.

[Antonio Gomes]

Comment on attachment 33656 [details]
v0.1 - code style fixes + removal of unneeded includes 

clearing review flag, since xan asked to break it down in smaller patches:

1) for coding style
2) for removing unneeded includes.

[Antonio Gomes]

Created attachment 33781 [details]
v0.2.1 - code style fixes

code style fixed pointed out by cpplint.py tool

[Antonio Gomes]

Created attachment 33782 [details]
v0.2.2 - removal of unneeded includes

unneeded includes removal.

[Antonio Gomes]

Created attachment 33788 [details]
v0.3.1 - code style fixes

kept NULL whereas compiler warning show up, suggested by kov

[Antonio Gomes]

please apply

v0.3.1 first then v0.2.2 on top.

[Antonio Gomes]

Created attachment 33789 [details]
v0.4.1 - code style fixes

fixed, changelog message.

again please apply v0.4.1 before, then 0.2.2

[Gustavo Noronha (kov)]

Comment on attachment 33789 [details]
v0.4.1 - code style fixes

> -    } else {
> +    } else
>          g_object_set(G_OBJECT(m_playBin), "volume", m_volume, NULL);
> -    }
> +
>  }

I'd remove this line.

> -            LOG_VERBOSE(Media, "m_source is NULL");
> +            LOG_VERBOSE(Media, "m_source is 0");

I think you want to keep this as NULL here.

Other than that looks good.

[Antonio Gomes]

Created attachment 33792 [details]
v0.5.1 - code style fixes 

fixed.

carrying kov's r+ for the previous patch

[Gustavo Noronha (kov)]

Comment on attachment 33792 [details]
v0.5.1 - code style fixes 

right, thanks!

[Gustavo Noronha (kov)]

Comment on attachment 33792 [details]
v0.5.1 - code style fixes 

Landed as r46587. Clearing review flag.

[Gustavo Noronha (kov)]

Comment on attachment 33782 [details]
v0.2.2 - removal of unneeded includes

Looks good.

[Gustavo Noronha (kov)]

Comment on attachment 33782 [details]
v0.2.2 - removal of unneeded includes

Landed as r46588.

[Gustavo Noronha (kov)]

This should do it =).