Bug 277657

Summary: Remove the indirection in isMouseFocusable() to call directly the quirk
Product: WebKit Reporter: Karl Dubost <karlcow>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P4 Keywords: GoodFirstBug, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Karl Dubost
Reported 2024-08-05 16:45:10 PDT
On https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/html/HTMLFormControlElement.cpp#492 there is ``` // FIXME: We should remove the quirk once <rdar://problem/47334655> is fixed. bool HTMLFormControlElement::needsMouseFocusableQuirk() const { return document().quirks().needsFormControlToBeMouseFocusable(); } ``` which is used in https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/html/HTMLFormControlElement.cpp#251-260 ``` bool HTMLFormControlElement::isMouseFocusable() const { #if (PLATFORM(GTK) || PLATFORM(WPE)) return HTMLElement::isMouseFocusable(); #else if (!!tabIndexSetExplicitly() || needsMouseFocusableQuirk()) return HTMLElement::isMouseFocusable(); return false; #endif } ``` it doesn't need the indirection. 1. The function should isMouseFocusable() should directly call document().quirks().needsFormControlToBeMouseFocusable() 2. Do not forget about moving the comment too.
Attachments
Radar WebKit Bug Importer
Comment 1 2024-08-05 16:45:21 PDT
Nathan Solomon
Comment 2 2024-08-09 14:31:22 PDT
EWS
Comment 3 2024-08-09 15:17:21 PDT
Committed 282062@main (76bcd3ed6795): <https://commits.webkit.org/282062@main> Reviewed commits have been landed. Closing PR #31972 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.