Bug 277654
| Summary: | run-webkit-tests exit code shouldn't depend on number of unexpected results | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | aakash_jain, emw, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=276081 | ||
Sam Sneddon [:gsnedders]
Currently, if we get the expected output but exit with non-zero, EWS will totally ignore this: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/CISupport/ews-build/steps.py#L4113-L4114
We practically have to do this, because the exit code is actually just the number of regressions: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/Scripts/webkitpy/port/base.py#L961-L966
It would be probably be better to define an exit code which means "we had regressions", as we then don't end up in situations where a single exit code can mean multiple things.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133250341>
Elliott Williams
I think this is fixed by the changes landed in https://bugs.webkit.org/show_bug.cgi?id=276081.
*** This bug has been marked as a duplicate of bug 276081 ***
Sam Sneddon [:gsnedders]
They got reverted in bug 277749 :(