Bug 277649
| Summary: | [fullscreen] Stop nesting event loop tasks in requestFullscreen | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | DOM | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
Tim Nguyen (:ntim)
https://github.com/WebKit/WebKit/commit/5d683d69a8da1a2b0a98e5b292700930fcb49ae0 added the inner one
https://github.com/WebKit/WebKit/commit/9434a77e1117ecc9775f97b910f5f5ca13c063ad added the outer one
The event loop tasks might just have ended up accidentally nested, the outer one just does pre-flight checks, the inner one just calls into the client. They can just be done in one event loop task.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133247401>
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/31748
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/41734
EWS
Committed 291478@main (0897ad201f82): <https://commits.webkit.org/291478@main>
Reviewed commits have been landed. Closing PR #41734 and removing active labels.